Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 7.1.2 & switch to gha ci for image deployments #41

Closed
wants to merge 1 commit into from
Closed

Bump version to 7.1.2 & switch to gha ci for image deployments #41

wants to merge 1 commit into from

Conversation

adamus1red
Copy link
Contributor

@adamus1red adamus1red commented Jul 18, 2021 •
edited
Loading

The GHA workflow pulls the version numbers to build from the SOPEL_BRANCH environment variable in the Dockerfile rather than relying on changing it in 3 different places.

Has a matrix build for the different supported python versions with Python 3.9 defaulting to be the "main" release version as the latest tag.

Also fixes #33

Example run of GHA action: adamus1red/docker-sopel/actions/runs/1042705230

New built-time secrets

  • IMAGE: name of the image to be tagged with (i.e. sopelirc/sopel)
  • DOCKER_USERNAME: Username to login to docker hub with.
  • DOCKER_PASSWORD: Access token to authenticate with docker hub.

@adamus1red
Switch to gha ci (#1)
7707ee9 
New secrets 

* IMAGE
* DOCKER_USERNAME 
* DOCKER_PASSWORD 

Co-authored-by: adamus1red <[email protected]>
@HumorBaby
Copy link
Contributor

oh boy, merging from master?? 😰
A lot of this looks good, and since I'm so behind on switch to GHA, I imagine we can use almost everything here…
however, I would like to request the following before a real review:

  • remove excess files from PR; I think your current branch has extra CI stuff, e.g., dependabot…??

then, I would like to discuss with you (and anyone else that wants to chime in) about:

  • splitting out multi-arch from a first-step straight-forward build+label+push. This can keep the multiple python versions as you are doing now. Once this is merged in a nice and clean state, let's 100% get multi-arch done.

Gotta run, but wanted to share my thoughts without further delay. Let me know what you think

@adamus1red
Copy link
Contributor Author

adamus1red commented Aug 2, 2021 •
edited
Loading 

* splitting out multi-arch from a first-step straight-forward build+label+push. This can keep the multiple python versions as you are doing now. Once this is merged in a nice and clean state, let's 100% get multi-arch done.

@HumorBaby I've split the single build into #42 with single arch build. After it is done I'll add the multi-arch on top.

I would like to request the following before a real review:

* remove excess files from PR; I think your current branch has extra CI stuff, e.g., dependabot…??

I added Dependabot to keep the actions that are used by GHA upto date.

@adamus1red adamus1red closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Add multi-arch builds
2 participants
@adamus1red @HumorBaby